On 16/01/2014 13:26, Geert Janssens wrote:
Gary,
While looking at your changes I noticed you changed two lines in the
vbs script.
One is that you added my repository/branch in a comment. That's ok and
makes it easier for others to start.
The second is to install msys-patch. Is there a reason you do this in
the vbs script and not in install-impl.sh ?
Geert
Hi Geert.
The reason I added in msys-patch to my version of your script is so that
the instructions I posted on the wiki would work, since they tell you to
run your vbs script and then run patch against the 2.6 repo with my
patchfile, and that doesn't work if you don't yet have patch installed.
Of course, as and when there's a git repo with the patches already
incorporated, that step is no longer needed and nor is patch. But it
doesn't do much harm to leave it around, and would make it easier for
people who have to play catch-up the next time a downstream dependency
gets broken.
Gary
_______________________________________________
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel
