I am curious, does a UNC path work with `git clone` on the command line? It's possible this happened as a side effect of strengthening the validation in 21.3.0 (https://www.gocd.org/releases/#21-3-0) due to https://github.com/gocd/gocd/security/advisories/GHSA-xx28-8pr9-6xqh
On Thu, Nov 10, 2022 at 6:50 AM Funkycybermonk <chant...@gmail.com> wrote: > It appears that I am able to change it from a unc path to a file protocol > path to get the slashes the other direction and it does work. I'm not sure > there is a specific reason but it actually seems to shave about 5 seconds > off the time to pull the resources in. > > If this isn't a concern for anything else, I think I'm ok, it just might > be helpful to Windows installs if there is a note that UNC paths no longer > work and to use file://path instead. > > Thanks! > > On Wednesday, November 9, 2022 at 3:15:12 PM UTC-6 Funkycybermonk wrote: > >> Hello! >> >> It appears that on start, 22.2/22.3 at least try to validate the git urls >> in my cruise xml. The issue is that it doesn't seem to allow windows file >> or unc paths like <git url="\\domain\path\somefolder\repo" />. I can change >> them to something else temporarily but it appears that the xml validation >> will always fail. Is there a way to add alternate git path formats without >> a new build of the server? Or, if there is just an alternate way of >> legitimately addressing a unc path in GoCD in a different format it >> accepts. We can't pull it from outside every time because these run >> frequently and its a cost overhead for data being pulled in so it gets >> expensive over time. >> >> It appears to be tested using class isValidURL in UrlArgumentTest.java >> but the error is being thrown from ScmMaterialConfig.java I think. >> >> Thanks! >> > -- > You received this message because you are subscribed to the Google Groups > "go-cd" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to go-cd+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/go-cd/862032f5-ba19-4d4b-8a2e-6ad542b96125n%40googlegroups.com > <https://groups.google.com/d/msgid/go-cd/862032f5-ba19-4d4b-8a2e-6ad542b96125n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "go-cd" group. To unsubscribe from this group and stop receiving emails from it, send an email to go-cd+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/go-cd/CAA1RwH-qm6uJa%3Dy-cQgm30BPfw7a1623NbWvNRWXrYJYWf7Ucw%40mail.gmail.com.
