On Tue, Nov 17, 2020 at 6:11 AM Than McIntosh <th...@google.com> wrote: > > > /home/oceanfish81/workarea/llvm-project/llvm/tools/gollvm/gofrontend/libgo/sysinfo.c:462:1: > > error: tentative definition has type 'struct sigstack' that is never > > completed > > SREF(sigstack); > > ^ > > I don't know why sysinfo.c has the line "SREF(sigstack)". What > happens if you just remove it? > > I agree, I would take it out and see what happens. > > The SREF(...) constructs in sysinfo.c are there to generate explicit > references to types mentioned in the C code from system header files, so as > to insure that DWARF gets generated for them (in case the C++ compiler being > used is clang, which does not support -fno-eliminate-unused-debug-types). > Looks like on Alpine (which is musl-based) there is no such type. Not clear > whether it is actually needed at this point, so it is worth trying without it.
As far as I can tell we never use the sigstack type in libgo, so my guess is that we don't need it. The sigstack type (really struct sigstack) was used for the old sigstack function, but that function has been replaced by sigaltstack. Ian -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving emails from it, send an email to golang-nuts+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/golang-nuts/CAOyqgcWQvFfMsEKG8CgVc9N0ukBBxp-JnazEHqpfXu6FgnOn8A%40mail.gmail.com.
