Karl, first and foremost: thanks for being the first person to contribute.
1. Yes, I just missed the makefile when I was cleaning things up. I'll remove that and update contributing.md to document how to run tests. In the meantime, you can checkout the travis config file. Mostly, you just need to install nox-automation and run nox -s tests. Travis ran for your PR and it passed <https://travis-ci.org/GoogleCloudPlatform/webapp2/builds/122147953>. 2. Enabling the CLA bot is standard procedure, and the OSS lawyer that assisted me in moving over this project did not indicate that it should be passed over. I am not lawyer, however, from what I understand t the CLA does not remove any of your rights as a the author, it just grants the project rights to your contribution (this seems to be pretty clearly stated at the beginning of the CLA itself). If concerns over the CLA cause you to not want to contribute further, I'll be happy to get you in contact our open source programs office so that we can potentially address your concerns. On Sunday, April 10, 2016 at 7:49:07 PM UTC-7, Karl MacMillan wrote: > > > On Apr 8, 2016, at 4:58 PM, 'Jon Parrott' via Google App Engine < > google-a...@googlegroups.com <javascript:>> wrote: > > In a previous thread > <https://groups.google.com/forum/#!topic/google-appengine/HazEmXZRpiw>, > several of you pointed out that webapp2 was abandoned and some of you > expressed interesting in helping maintain the project. > > > Jon, > > Thanks for stepping up and making this happen. I’ve submitted a pull > request for the bug that I mentioned in that thread. > > Two things: > > 1) Is all of the test infrastructure checked in? I ask because the > Makefile (and the test target) are referencing a non-existent run_tests.py > in the root of the project. I also didn’t see any documentation on how to > run the tests, especially the ones with GAE dependencies. > > 2) Is it intentional that a CLA is being required to submit patches? I’m > not a CLA fan in general, but I understand that they may make sense in some > contexts. However, in this case it seems unfortunate and potentially > pointless to take a community project, pull it in as a Google project, and > then require a CLA. It’s not like you have the copyright grant for all of > the previous work so that requiring the CLA for new patches actually gets > you any sort of licensing freedom or full patent protection. If you really > want to go with this approach I’ll sign the CLA for this trivial patch, but > it will likely discourage me from any other contribution. (I hate to keep > complaining since you’ve done so much to move this forward - it’s just that > this seems like a really strange approach to take). > > Thanks - Karl > > I'm happy to provide an update. The original author has allowed the Google > Cloud Platform Developer Relations team to assume ownership of webapp2. > We've moved the project to github and we're ready to accept pull requests. > > - webapp2 now lives at GoogleCloudPlatform/webapp2 > <https://github.com/GoogleCloudPlatform/webapp2>. > - Tests are running on travis > <https://travis-ci.org/GoogleCloudPlatform/webapp2> and code coverage > reporting > <https://codecov.io/github/GoogleCloudPlatform/webapp2?branch=master>. > - The documentation is now published to readthedocs > <http://webapp2.readthedocs.org/en/latest/>. > - The official website will soon be updated to redirect to readthedocs. > > We could really use the community's help to: > > - Test it! We cleaned up a bit of stuff and we want to make sure that > everything still works as expected. > - Check the new documentation > <http://webapp2.readthedocs.org/en/latest/> for accuracy and report > any content errors or bad links. > - Triage the issues > > <https://github.com/GoogleCloudPlatform/webapp2/issues?q=is%3Aissue+is%3Aopen+label%3Aauto-migrated> > > that were transferred over from the original project. If you want to just > review them and comment whether or not they are still relevant, that would > be super helpful. > - Fix issues. :) > > We'll soon release version 3.0.0 to PyPI. This is to mark the ownership > transition. We will look into updating the version included with Google App > Engine. > > -- > You received this message because you are subscribed to the Google Groups > "Google App Engine" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to google-appengi...@googlegroups.com <javascript:>. > To post to this group, send email to google-a...@googlegroups.com > <javascript:>. > Visit this group at https://groups.google.com/group/google-appengine. > To view this discussion on the web visit > https://groups.google.com/d/msgid/google-appengine/9a193edb-363d-4ce9-b64f-b0b818f5cd14%40googlegroups.com > > <https://groups.google.com/d/msgid/google-appengine/9a193edb-363d-4ce9-b64f-b0b818f5cd14%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > > > -- You received this message because you are subscribed to the Google Groups "Google App Engine" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-appengine+unsubscr...@googlegroups.com. To post to this group, send email to google-appengine@googlegroups.com. Visit this group at https://groups.google.com/group/google-appengine. To view this discussion on the web visit https://groups.google.com/d/msgid/google-appengine/c515d101-f028-4240-8e34-2334a45725b4%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
