Updated patch attached. M user/test/com/google/gwt/user/UISuite.java M user/test/com/google/gwt/user/client/ui/CompositeTest.java A user/test/com/google/gwt/user/client/ui/LazyPanelTest.java M user/src/com/google/gwt/user/client/ui/DisclosurePanel.java A user/src/com/google/gwt/user/client/ui/LazyPanel.java M user/src/com/google/gwt/user/client/ui/TabPanel.java
On Wed, Nov 19, 2008 at 2:26 PM, Emily Crutcher <[EMAIL PROTECTED]> wrote: > *LazyPanelTest: > *I like your MyLazyPanel, seems like a good model to use for testing this. > > I think we should add tests that ensure that the create is triggered when > called in a TabPanel,StackPanel, (soon) DisclosurePanel, and ensureWidget(). Done, including the change to DisclosurePanel. But I'm testing the more fundamental DeckPanel rather than TabPanel. > > > *LazyPanel: > *We should probably decide as a group if we want to document no-arg > constructors or not. It's kinda odd to document just some of them. Seems like that's already decided by the fact that the style nazi tool doesn't require them. > > > *setVisible* javadoc: > childe --> child Fixed > > It does not create the widget each time, so can we reword the javadoc a > little bit? "creates the sole child widget if necessary" I'm not sure how to make it clearer than that. > > > *setVisible:* > I wonder if we should actually reverse the order, and call > super.setVisible() first? I can't really see why. I can imagine it being better to create the new widget before making it visible--my normal habit to avoid flicker, though that shouldn't be an issue here. > > > > > On Wed, Nov 19, 2008 at 11:50 AM, Ray Ryan <[EMAIL PROTECTED]> wrote: > >> Here's the bulk of the work introducing LazyPanel. I'll send a follow up >> patch that reworks ShowCase to use it soon. >> You'll note that the javadoc references an example that doesn't exist yet. >> It's written, but I'll send a separate patch when it's been tested. >> >> Issues: >> >> 1. I don't like the fact that it's a panel, inheriting a useless list and >> extra API, and find myself wishing for, say, LazyComposite instead. Is there >> any particular reason it wasn't written that way originally? >> >> 2. I chatted with jlabanca, and we think it would be a good idea to tweak >> DisclosurePanel so that it calls setVisible(true) on its wrapped children >> before exposing them, to make it LazyPanel friendly the same way that >> DeckPanel and StackPanel already are. >> >> rjrjr >> >> > > > -- > "There are only 10 types of people in the world: Those who understand > binary, and those who don't" > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
hello-lazy-panel-1.6-r4130.patch
Description: Binary data
