> > Fixed > >> >> It does not create the widget each time, so can we reword the javadoc a >> little bit? > > > "creates > the sole child widget if necessary" I'm not sure how to make it clearer than > that. >
Sorry, somehow managed to lose the "if necessary" stanza the first time I read it. Yes, that is perfectly clear. > > >> >> *setVisible:* >> I wonder if we should actually reverse the order, and call >> super.setVisible() first? > > > I can't really see why. I can imagine it being better to create the new > widget before making it visible--my normal habit to avoid flicker, though > that shouldn't be an issue here. > Only potential problem is that if the new widget needs to calculate height/width information, those will be wrong if it is currently wrapped in a display none block. On the other hand, given that this is a new API, it seems equality valid to just not allow that sort of code. Also, I assume you still know that you don't have a a LazyPanel example in this review? --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
