Thanks. Committed as r1319.
On Mon, Dec 15, 2008 at 5:14 PM, Emily Crutcher <e...@google.com> wrote:
> LGTM.
>
> On Mon, Dec 15, 2008 at 4:51 PM, Isaac Truett <itru...@gmail.com> wrote:
>>
>> Good enough for me. Here's the patch for building demos off of the jar:
>>
>> Index: build.xml
>> ===================================================================
>> --- build.xml (revision 1316)
>> +++ build.xml (working copy)
>> @@ -371,8 +371,7 @@
>> vmMaxMemory="${gwtc.vm.maxMemory}">
>> <classpath>
>> <path path="${gwtc.src.dir}" />
>> - <path path="${project.src}" />
>> - <path path="${project.bin}" />
>> + <path path="${project.jar}" />
>> <pathelement location="${gwt.user.jar}" />
>> <pathelement location="${gwt.dev.jar}" />
>> <pathelement location="${gwt.tools}/lib/w3c/sac/sac-1.3.jar" />
>>
>>
>> Any objections?
>>
>>
>> On Mon, Dec 15, 2008 at 4:43 PM, Emily Crutcher <e...@google.com> wrote:
>> > The reasons I would prefer to use the gwt-incubator.jar is because that
>> > gives us a quick sanity check that the gwt-incubator jar is actually
>> > including everything needed to run the demos!
>> >
>> >>
>> >> + project.src and project.bin can be overridden, if desired (super
>> >> could be overridden if it used a variable, which it probably should)
>> >
>> > If project.src or project.bin was overridden, those changes should be
>> > reflected in the gwt-incubator jar, if they are not, that is definitely
>> > a
>> > problem we would want to catch sooner rather then later.
>> >
>> >>
>> >> + build-demos doesn't depend on building a jar first
>> >
>> >
>> > The gwt-incubator jar currently takes 12 seconds to compile on my
>> > relatively
>> > slow laptop, so depending upon the gwt-incubator build running first
>> > does
>> > not seem like it introduces an undue burden on the developer.
>> >
>> >
>> > cheers,
>> >
>> > Emily
>> >
>> > >
>> >
>>
>>
>
>
>
> --
> "There are only 10 types of people in the world: Those who understand
> binary, and those who don't"
>
> >
>
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
