http://gwt-code-reviews.appspot.com/2205/diff/1/6 File user/src/com/google/gwt/event/Event.gwt.xml (right):
http://gwt-code-reviews.appspot.com/2205/diff/1/6#newcode2 Line 2: <source path="shared"/> Totally agreed about the overall goal. I was suggesting a slight naming change: gwt.foo.Foo --> in general means get the entire package. gwt.foo.FooBase --> gets just the stuff absolutely needed for the sub-packages to work. So, for events gwt.event.Event --> gets all the currently defined gwt event structure. gwt.event.EventBase -> gets the core infrastructure needed. The only other thing is rather then having DomEvent extend User, why don't we have DomEvent extend com.google.gwt.user.DOM? http://gwt-code-reviews.appspot.com/2205/diff/43/230 File user/src/com/google/gwt/event/logical/shared/ValueChangeEvent.java (right): http://gwt-code-reviews.appspot.com/2205/diff/43/230#newcode42 Line 42: if (source.isEventHandled(TYPE)) { On 2009/01/15 20:35:56, rjrjr wrote: > Why is this fire method more complicated than all the other ones? No one else > bothers with the isEventHandled check. I think it was from before we made up our minds on whether to check before creating them. http://gwt-code-reviews.appspot.com/2205/diff/43/221 File user/src/com/google/gwt/event/shared/HandlerManager.java (right): http://gwt-code-reviews.appspot.com/2205/diff/43/221#newcode58 Line 58: return false; It has already been removed. http://gwt-code-reviews.appspot.com/2205/diff/43/236 File user/src/com/google/gwt/user/client/ui/ListenerWrapper.java (right): http://gwt-code-reviews.appspot.com/2205/diff/43/236#newcode93 Line 93: abstract class ListenerWrapper<T> implements EventHandler { I think we might need to rename the inner classes of ListenerWrapper before making it public (having eclipse control-shift T "Tree" bring up ListenerWrapper.Tree is not ideal), so we might want to wait until after this patch clears. On 2009/01/15 20:35:56, rjrjr wrote: > Elsewhere we said that we would make this class public (and deprecated), as lots > of people are in the same boat we are wrt event conversion. Might as well make > that change in this patch. http://gwt-code-reviews.appspot.com/2205 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
