I know this is a bit late, but is it true that we will now need to be more aggressive about deploying servlet classes? Is the obfuscated name mapping stable if new type names are added?
On Wed, Feb 18, 2009 at 8:15 PM, BobV <b...@google.com> wrote: > > Thanks for the review. > >> SerializerBase contains the comment "Relies on monotonic behavior of >> hashcodes in web mode". I see no problem with this (and I've wanted to do so >> for JRE stuff at times), but I don't think we've ever explicitly stated this >> as a requirement of System.identityHashCode(). We should, at a minimum, >> document this requirement in our implementation of >> identityHashCode()/Impl.getHashCode(), so we don't inadvertently break it. > > Comments updated. > >> SerializerBase.MethodMap is a JSO whose methods are non-final. Do you know >> why this is working? Do we only run JSO constraint-checking in hosted mode? > > MethodMap is a final class. > >> Nits: >> ClientSerializationStreamWriter:57,82,96: JSNI reformat cruft. >> StandardSerializationPolicy:55: Double semicolons. >> ServerSerializationStreamWriter:412: Comment reformatting cruft >> (right-shifted notes). > > Fixed cruft. > >> All that said, once you feel comfortable with it go ahead and commit away. >> I've run it against some pretty big projects without incident thus far, >> so... Good work! > > Merged to trunk at r4790. > > -- > Bob Vawter > Google Web Toolkit Team > > > > -- Eric Z. Ayers - GWT Team - Atlanta, GA USA http://code.google.com/webtoolkit/ --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
