Thanks for the review. > SerializerBase contains the comment "Relies on monotonic behavior of > hashcodes in web mode". I see no problem with this (and I've wanted to do so > for JRE stuff at times), but I don't think we've ever explicitly stated this > as a requirement of System.identityHashCode(). We should, at a minimum, > document this requirement in our implementation of > identityHashCode()/Impl.getHashCode(), so we don't inadvertently break it.
Comments updated. > SerializerBase.MethodMap is a JSO whose methods are non-final. Do you know > why this is working? Do we only run JSO constraint-checking in hosted mode? MethodMap is a final class. > Nits: > ClientSerializationStreamWriter:57,82,96: JSNI reformat cruft. > StandardSerializationPolicy:55: Double semicolons. > ServerSerializationStreamWriter:412: Comment reformatting cruft > (right-shifted notes). Fixed cruft. > All that said, once you feel comfortable with it go ahead and commit away. > I've run it against some pretty big projects without incident thus far, > so... Good work! Merged to trunk at r4790. -- Bob Vawter Google Web Toolkit Team --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
