Still trying to see how this can happen in practice. The only way I can get the expression !!o.nodeType to give the aforementioned error on IE is to set o to null or undefined. This could happen (on any browser) if event.target is null, but that *should* be illegal. We could try to work around this by adding a null check in Node.is() (or upstream in PopupPanel.eventTargetsPopup()), but I'd really like to see precisely what went wrong before getting quite that defensive. Is there any chance you could provide a code snippet that causes this in practice? I know we have tables in popups all over the place, because the DialogBox class does this (by using a DockPanel in a PopupPanel), so it's got to be a bit more subtle or complex than that.
Thanks, joel. On Mon, Mar 30, 2009 at 3:01 PM, Joel Webber <j...@google.com> wrote: > I made some changes in event handling for 1.6, which might have caused this > (though it's not yet immediately obvious how). I'll be digging into it > tonight -- everyone please update this thread if any more information > surfaces. > > > On Mon, Mar 30, 2009 at 8:25 AM, nicolas de loof <nicolas.del...@gmail.com > > wrote: > >> Some more infos about this bug : >>> it happens in eventTargetsPopup as the NativeEvent beeing passed has no >>> eventTarget set. >>> >>> Find attached a screen capture from the developper that detected this >>> issue. Maybe the stacktrace can help you. >>> >>> >>> >>> >>> On Fri, Mar 27, 2009 at 6:07 PM, Scott Blum <sco...@google.com> wrote: >>> >>>> Do you know what event this was? What do you do with the popup to get >>>> it to trigger? Or does it just happen with no user interaction? >>>> >>>> >>>> On Fri, Mar 27, 2009 at 11:46 AM, nicolas de loof < >>>> nicolas.del...@gmail.com> wrote: >>>> >>>>> Some more infos : >>>>> We got this exception running in hosted mode browser (with -noserver) >>>>> on windows >>>>> No error when using an empty PopupPanel, also fine when containing a >>>>> label, but fails when including a Table. >>>>> >>>>> Hope this helps ... >>>>> >>>>> >>>>> On Fri, Mar 27, 2009 at 3:57 PM, Thomas Broyer <t.bro...@gmail.com>wrote: >>>>> >>>>>> >>>>>> >>>>>> >>>>>> On 26 mar, 19:18, John Tamplin <j...@google.com> wrote: >>>>>> > On Thu, Mar 26, 2009 at 1:40 PM, Scott Blum <sco...@google.com> >>>>>> wrote: >>>>>> > > That's not good.... it looks like Nicolas found an object for >>>>>> which trying >>>>>> > > to evaluate (!!o.nodeType) throws an exception. >>>>>> > >>>>>> > If my atrophied high-school French is correct, I believe the error >>>>>> is that o >>>>>> > is null at that point. >>>>>> >>>>>> It actually says that 'nodeType' (not 'o'!) is Null or is not an >>>>>> object. >>>>>> >>>>>> The thing is: I cannot understand why IE (this looks like an IE >>>>>> exception message, don't you think?) would throw such an exception >>>>>> while evaluating "!!" on such a null/undefined (it would effectively >>>>>> throw if 'o' were null, but it would say that "'o' is null or is not >>>>>> an object", or if we were trying to get or set a property or call a >>>>>> method on o.nodeType). >>>>>> >>>>>> Am I wrong? >>>>>> >>>>>> >>>>> >>>>> >>>>> >>>> >>>> >>>> >>> >> >> >> >> > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
