Looks good, modulo my comment about repeating method declarations in the
formatter interfaces.


http://gwt-code-reviews.appspot.com/49802/diff/1/5
File user/src/com/google/gwt/user/client/ui/RichTextArea.java (right):

http://gwt-code-reviews.appspot.com/49802/diff/1/5#newcode485
Line 485: void undo();
Is there any particular reason for copying all the basic and extended
formatter methods into this derived interface? Couldn't we just leave
them where they are until the deprecated interfaces are removed? I doubt
it makes a substantive difference, but it seems kind of smelly.

http://gwt-code-reviews.appspot.com/49802

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to