I can't attach a new patch to the issue since I don't own it, but here is the updated patch that we pair programed. It fixes the problems uncovered by the unit test. This patch should be applied over patch set 3.
On Tue, Oct 20, 2009 at 11:06 AM, <mmen...@google.com> wrote: > I found a couple of failures on my OSX box last night. Let's look at > them together. > > > http://gwt-code-reviews.appspot.com/81805/diff/2003/2007 > File > dev/core/test/com/google/gwt/dev/shell/remoteui/MessageTransportTest.java > (right): > > http://gwt-code-reviews.appspot.com/81805/diff/2003/2007#newcode110 > Line 110: MessageTransport messageTransport = new MessageTransport( > Nit: messageTransport - Unused local. > > http://gwt-code-reviews.appspot.com/81805/diff/2003/2007#newcode151 > Line 151: public void testExecuteAsyncRequestWithClosedSendStream() > throws IOException, > This fails sporadically for me on OSX JRE 1.5.0, but not OSX JRE 1.6.0. > > http://gwt-code-reviews.appspot.com/81805/diff/2003/2007#newcode322 > Line 322: public void > testExecuteRequestAsyncWithClosedReceiveStreamBeforeResponse() > This fails sporadically for me on OSX JRE 1.5.0, but not OSX JRE 1.6.0. > > > http://gwt-code-reviews.appspot.com/81805 > -- Miguel --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
