Mostly LGTM

http://gwt-code-reviews.appspot.com/103812/diff/2002/2003
File dev/core/src/com/google/gwt/dev/DevMode.java (right):

http://gwt-code-reviews.appspot.com/103812/diff/2002/2003#newcode359
Line 359: ((JettyLauncher) scl).setBaseLogLevel(getBaseLogLevelForUI());
What about GAE or other SCLs?  I think it might be better to use
reflection here instead, so if they implement this method they can get
the log level.

http://gwt-code-reviews.appspot.com/103812/diff/2002/2004
File dev/core/src/com/google/gwt/dev/DevModeBase.java (right):

http://gwt-code-reviews.appspot.com/103812/diff/2002/2004#newcode579
Line 579: public static String normalizeURL(String unknownUrlText, int
port, String host) {
Too long

http://gwt-code-reviews.appspot.com/103812/diff/2002/2005
File dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java
(right):

http://gwt-code-reviews.appspot.com/103812/diff/2002/2005#newcode55
Line 55: private final TreeLogger.Type logLevelForNonErrorHttpStatus;
This is overly verbose -- how about normalLogLevel?

http://gwt-code-reviews.appspot.com/103812

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to