New patch for review.

http://gwt-code-reviews.appspot.com/394801/diff/1/2
File user/src/com/google/gwt/uibinder/rebind/MortalLogger.java (right):

http://gwt-code-reviews.appspot.com/394801/diff/1/2#newcode102
user/src/com/google/gwt/uibinder/rebind/MortalLogger.java:102: +
location.getLineNumber() + ")");
The location is now logged on the same line.

http://gwt-code-reviews.appspot.com/394801/diff/1/3
File user/src/com/google/gwt/uibinder/rebind/W3cDomHelper.java (right):

http://gwt-code-reviews.appspot.com/394801/diff/1/3#newcode48
user/src/com/google/gwt/uibinder/rebind/W3cDomHelper.java:48: private
class MyHandler extends DefaultHandler2 {
Moved to a top-level class.

http://gwt-code-reviews.appspot.com/394801/diff/1/3#newcode118
user/src/com/google/gwt/uibinder/rebind/W3cDomHelper.java:118:
Attributes attributes) throws SAXException {
You could do normalization here so you don't have to worry too much
about reworking an already-cooked DOM.  This could behave like the
ReflectiveParser that's used for processing the module XML.

http://gwt-code-reviews.appspot.com/394801/diff/1/3#newcode134
user/src/com/google/gwt/uibinder/rebind/W3cDomHelper.java:134: public
void warning(SAXParseException exception) throws SAXException {
Done.

http://gwt-code-reviews.appspot.com/394801/diff/1/6
File user/test/com/google/gwt/uibinder/rebind/MockMortalLogger.java
(right):

http://gwt-code-reviews.appspot.com/394801/diff/1/6#newcode40
user/test/com/google/gwt/uibinder/rebind/MockMortalLogger.java:40:
super.die(context, message, params);
This has been reworked a bit in the new patch.

http://gwt-code-reviews.appspot.com/394801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to