LGTM. HtmlUnit should be used; it should be uncommented everywhere. I uncommented a few things in r7787 (link below), but it seems like I missed a few instances.
http://code.google.com/p/google-web-toolkit/source/detail?r=7787&path=/trunk/user/build.xml One nit : the assertion that "ant -f user/build.xml test" doesn't do anything seems incorrect. It still runs HtmlUnit tests. No? This patch fixes ant test.dev, ant test.web, and other similar targets. > > On Wed, May 5, 2010 at 5:52 PM, <sco...@google.com> wrote: > >> Reviewers: amitmanjhi, jlabanca, >> >> Description: >> Sorry, for some reason side-by-side diff isn't working for me. >> >> This patch is to alleviate the fact that: >> >> ant -f user/build.xml test >> >> Does practically nothing. Even if hmtlunit is somewhat flaky, it's >> gotten be better than nothing. >> >> Please review this at http://gwt-code-reviews.appspot.com/475801/show >> >> Affected files: >> user/build.xml >> >> >> Index: user/build.xml >> diff --git a/user/build.xml b/user/build.xml >> index >> cac355b5497b7266b714f9ef724bb8476e448b8c..8ffde00190d4b22537009bffbee8ac2f968e9633 >> 100755 >> --- a/user/build.xml >> +++ b/user/build.xml >> @@ -52,6 +52,7 @@ >> <pathelement location="${gwt.tools.lib}/easymock/easymock.jar"/> >> <pathelement >> location="${gwt.tools.lib}/easymock/easymockclassextension.jar"/> >> <pathelement location="${gwt.tools.lib}/objectweb/asm-3.1.jar"/> >> + <pathelement location="${gwt.dev.jar}" /> >> </path> >> >> <!-- Platform shouldn't matter here, just picking one --> >> @@ -97,15 +98,9 @@ >> destdir="${javac.junit.out}"> >> <classpath> >> <pathelement location="${javac.out}" /> >> - <pathelement location="${gwt.build}/out/dev/bin-test" /> >> - <pathelement >> location="${gwt.tools.lib}/tomcat/servlet-api-2.5.jar" /> >> <pathelement location="${gwt.tools.lib}/junit/junit-3.8.1.jar" /> >> <pathelement >> location="${gwt.tools.lib}/selenium/selenium-java-client-driver.jar" /> >> - <pathelement location="${gwt.tools.lib}/cglib/cglib-2.2.jar"/> >> - <pathelement location="${gwt.tools.lib}/easymock/easymock.jar"/> >> - <pathelement >> location="${gwt.tools.lib}/easymock/easymockclassextension.jar"/> >> - <pathelement location="${gwt.tools.lib}/objectweb/asm-3.1.jar"/> >> - <pathelement location="${gwt.dev.jar}" /> >> + <path refid="test.extraclasspath" /> >> </classpath> >> </gwt.javac> >> </target> >> @@ -506,9 +501,7 @@ >> <limit failonerror="true" hours="${test.timeout}"> >> <parallel threadsPerProcessor="${gwt.threadsPerProcessor}" >> threadCount="${gwt.threadCount}"> >> - <!-- disable HtmlUnit until it is reliable >> <antcall target="test.dev.htmlunit"/> >> - --> >> <!-- no-op unless gwt.hosts.dev.remote is defined --> >> <antcall target="test.dev.remote"/> >> <!-- no-op unless gwt.hosts.dev.selenium is defined --> >> @@ -527,9 +520,7 @@ >> <limit failonerror="true" hours="${test.timeout}"> >> <parallel threadsPerProcessor="${gwt.threadsPerProcessor}" >> threadCount="${gwt.threadCount}"> >> - <!-- disable HtmlUnit until it is reliable >> <antcall target="test.web.htmlunit"/> >> - --> >> <!-- no-op unless gwt.hosts.web.remote is defined --> >> <antcall target="test.web.remote"/> >> <!-- no-op unless gwt.hosts.web.selenium is defined --> >> @@ -548,9 +539,7 @@ >> <limit failonerror="true" hours="${test.timeout}"> >> <parallel threadsPerProcessor="${gwt.threadsPerProcessor}" >> threadCount="${gwt.threadCount}"> >> - <!-- disable HtmlUnit until it is reliable >> <antcall target="test.emma.htmlunit"/> >> - --> >> <!-- no-op unless gwt.hosts.dev.remote is defined --> >> <antcall target="test.emma.remote"/> >> <!-- no-op unless gwt.hosts.dev.selenium is defined --> >> @@ -569,9 +558,7 @@ >> <limit failonerror="true" hours="${test.timeout}"> >> <parallel threadsPerProcessor="${gwt.threadsPerProcessor}" >> threadCount="${gwt.threadCount}"> >> - <!-- disable HtmlUnit until it is reliable >> <antcall target="test.draft.htmlunit"/> >> - --> >> <!-- no-op unless gwt.hosts.web.remote is defined --> >> <antcall target="test.draft.remote"/> >> <!-- no-op unless gwt.hosts.web.selenium is defined --> >> @@ -590,9 +577,7 @@ >> <limit failonerror="true" hours="${test.timeout}"> >> <parallel threadsPerProcessor="${gwt.threadsPerProcessor}" >> threadCount="${gwt.threadCount}"> >> - <!-- disable HtmlUnit until it is reliable >> <antcall target="test.web.htmlunit"/> >> - --> >> <!-- no-op unless gwt.hosts.web.remote is defined --> >> <antcall target="test.nometa.remote"/> >> <!-- no-op unless gwt.hosts.web.selenium is defined --> >> >> >> > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
