LGTM with nits.
http://gwt-code-reviews.appspot.com/626801/diff/1/2 File dev/core/super/com/google/gwt/lang/LongLib.java (right): http://gwt-code-reviews.appspot.com/626801/diff/1/2#newcode58 dev/core/super/com/google/gwt/lang/LongLib.java:58: sb.append('\''); Why do we need quotes? http://gwt-code-reviews.appspot.com/626801/diff/1/2#newcode354 dev/core/super/com/google/gwt/lang/LongLib.java:354: Spaces. http://gwt-code-reviews.appspot.com/626801/diff/1/3 File dev/core/test/com/google/gwt/lang/LongLibTest.java (right): http://gwt-code-reviews.appspot.com/626801/diff/1/3#newcode451 dev/core/test/com/google/gwt/lang/LongLibTest.java:451: Spaces. http://gwt-code-reviews.appspot.com/626801/diff/1/3#newcode608 dev/core/test/com/google/gwt/lang/LongLibTest.java:608: Spaces. http://gwt-code-reviews.appspot.com/626801/diff/1/11 File user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java (right): http://gwt-code-reviews.appspot.com/626801/diff/1/11#newcode437 user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java:437: + SERIALIZATION_STREAM_VERSION_5 + " or " This looks like it will get ugly if we start supporting a wider version range. I suggest having *_MIN_VERSION and *_MAX_VERSION and making sure the client's version is in the range instead. Also, I am not positive we need to support multiple versions, since it is unlikely that the RPC signatures haven't changed at all while the client was recompiled with a new RPC wire format. However, I think we may be doing things that make it more likely to do this and I don't think anything here is particularly expensive, so I am fine with having the server support multiple versions. http://gwt-code-reviews.appspot.com/626801/diff/1/13 File user/test/com/google/gwt/user/server/rpc/RPCTest.java (right): http://gwt-code-reviews.appspot.com/626801/diff/1/13#newcode199 user/test/com/google/gwt/user/server/rpc/RPCTest.java:199: + "|echo|J|1|2|3|4|1|5|1.985229328E9|-8.1985531201716224E16|"; Please expand this like the V4 request so the fields can be commented. http://gwt-code-reviews.appspot.com/626801/diff/1/13#newcode208 user/test/com/google/gwt/user/server/rpc/RPCTest.java:208: + "|echo|J|1|2|3|4|1|5|'P7cuph2VDIQ'|"; Likewise here. Why do we need quotes around the base64 value? http://gwt-code-reviews.appspot.com/626801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
