LGTM
http://gwt-code-reviews.appspot.com/626801/diff/1/2 File dev/core/super/com/google/gwt/lang/LongLib.java (right): http://gwt-code-reviews.appspot.com/626801/diff/1/2#newcode58 dev/core/super/com/google/gwt/lang/LongLib.java:58: sb.append('\''); On 2010/06/16 20:13:28, Dan Rice wrote:
Fields in the RPC stream are JS literals that get eval'ed by ClientSerializationStreamReader.eval. The quotes make it a string
literal. I
can move the quoting login into the RPC code, the cost being spinning
up an
additional StringBuilder.
Ok, from FTF discussion we figured out they aren't needed on C->S messages because the server is just doing a split, but S->C is processed by an eval. http://gwt-code-reviews.appspot.com/626801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
