It was committed, and should have hit svn by now. I can't check that system right now, but can look in the morning if it's still wonky.
On Jul 15, 2010 5:41 PM, "Konstantin Scheglov" < konstantin.scheg...@gmail.com> wrote: >> The most natural spot to hook in would >> be com.google.gwt.uibinder.rebind.XMLElement.consumeAttributeWithDefault(String, >> String, JType[]), which I believe is the only way to get the value of an >> attribute from the parsed XML. > > > Aha! > Yes, using XMLElement.consumeX() methods also will work and even better, > because of support all parsers, even custom ones (if/when they will be added > into UiBinder). > > I've implemented such approach and it seems to work. > So, I can post new patch (tomorrow). > I'm only now sure how to do this. > Should I wait to commit of previous patch (I don't see it yet in SVN)? > Or you have not committed it yet? > Should I post new patch as new patch set in same issue, or open new one? > > > >> >> >> On Thu, Jul 15, 2010 at 10:29 AM, Ray Ryan <rj...@google.com> wrote: >> >>> Konstantin, I just submitted this but I'm starting to wonder about it. >>> There are lots of custom parsers that consume lots of attributes (e.g. the >>> various layout panel parsers). Why don't they need to call putAttribute >>> explicitly the way CellPanelParser did? If they do, and leaving them out was >>> an oversight, we need a more general mechanism that will just keep working >>> as new parsers are written, or this kind of mistake will plague us. >>> >>> >>> On Thu, Jul 15, 2010 at 8:49 AM, <rj...@google.com> wrote: >>> >>>> LGTM >>>> >>>> Thanks for the interface on UiBinderWriter, should have done that a long >>>> time ago. I'll probably tweak it's name while submitting. >>>> >>>> >>>> >>>> >>>> http://gwt-code-reviews.appspot.com/693801/show >>>> >>> >>> >> > > > -- > Konstantin Scheglov, > Instantiations, Inc. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
