will update this patch to rebase against your pending changes
http://gwt-code-reviews.appspot.com/704803/diff/1/2 File dev/core/src/com/google/gwt/dev/Compiler.java (right): http://gwt-code-reviews.appspot.com/704803/diff/1/2#newcode207 dev/core/src/com/google/gwt/dev/Compiler.java:207: Event precompileEventEvent = SpeedTracerLogger.start(CompilerEventType.PRECOMPILE); On 2010/08/05 18:33:08, zundel wrote:
Did you mean this to be named with the double suffix EventEvent?
whoops, nope. http://gwt-code-reviews.appspot.com/704803/diff/1/2#newcode211 dev/core/src/com/google/gwt/dev/Compiler.java:211: SpeedTracerLogger.end(precompileEventEvent); On 2010/08/05 18:33:08, zundel wrote:
what do you think about changing this to
precompileEvent.end()
I thought about this but decided not to simply because Event.end() would end up redirecting as the same function call since it needs to have the threadPendingEvents, etc.. Since they are functionally equivalent I didn't see a big win by doing that refactor. http://gwt-code-reviews.appspot.com/704803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors