http://gwt-code-reviews.appspot.com/704803/diff/1/2
File dev/core/src/com/google/gwt/dev/Compiler.java (right):

http://gwt-code-reviews.appspot.com/704803/diff/1/2#newcode211
dev/core/src/com/google/gwt/dev/Compiler.java:211:
SpeedTracerLogger.end(precompileEventEvent);
It's shorter.  If you *don't* do what Eric's suggesting, why are you
doing this change at all?

http://gwt-code-reviews.appspot.com/704803/diff/1/23
File
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
(right):

http://gwt-code-reviews.appspot.com/704803/diff/1/23#newcode59
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:59:
public class Event {
Maybe split out public interface / private implementation like with
EventType?

http://gwt-code-reviews.appspot.com/704803/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to