LGTM

Does this fix the pinning of CCL as well?


http://gwt-code-reviews.appspot.com/766803/diff/1/7
File user/src/com/google/gwt/i18n/rebind/ResourceFactory.java (right):

http://gwt-code-reviews.appspot.com/766803/diff/1/7#newcode64
user/src/com/google/gwt/i18n/rebind/ResourceFactory.java:64: // do
nothing. Remove all callers and then balete me
Make this a TODO, fix spelling of delete

http://gwt-code-reviews.appspot.com/766803/diff/1/8
File
user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java
(right):

http://gwt-code-reviews.appspot.com/766803/diff/1/8#newcode49
user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java:49:
private static final Map<TypeOracle, Map<String, Object>> CACHES =
Doesn't this need a @SuppressWarnings("unchecked")?

http://gwt-code-reviews.appspot.com/766803/diff/1/8#newcode77
user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java:77:
protected AbstractResourceContext(
I think something is wrong with your formatter here, as the line wasn't
over 80 chars.

http://gwt-code-reviews.appspot.com/766803/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to