http://gwt-code-reviews.appspot.com/766803/diff/1/2 File dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java (right):
http://gwt-code-reviews.appspot.com/766803/diff/1/2#newcode499 dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java:499: * manage static state. On 2010/08/19 01:04:10, scottb wrote:
Maybe we should tell them how they *should* manage static state?
agreed. though i think we should figure that out in a subsequent change. http://gwt-code-reviews.appspot.com/766803/diff/1/3 File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (right): http://gwt-code-reviews.appspot.com/766803/diff/1/3#newcode223 dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java:223: Collections.synchronizedMap(new HashMap<String, CompilationUnit>()); On 2010/08/19 01:04:10, scottb wrote:
Can you explain this change?
Though the previous method used a weak reference key, it was caching based on the resourceTag. So, when a new version appears, it has a new resourceTag which meant the size of the cache incorrectly increased. With this change, we just cache based on location. So, a new version in the same location will overwrite its old cache entry. http://gwt-code-reviews.appspot.com/766803/diff/1/5 File user/src/com/google/gwt/i18n/rebind/LocaleUtils.java (left): http://gwt-code-reviews.appspot.com/766803/diff/1/5#oldcode109 user/src/com/google/gwt/i18n/rebind/LocaleUtils.java:109: } On 2010/08/19 01:04:10, scottb wrote:
So when does this ever get cleared now?
FWIW, this wasn't getting called before, so this is really a null change. I'll look at fixing this properly... http://gwt-code-reviews.appspot.com/766803/diff/1/8 File user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java (right): http://gwt-code-reviews.appspot.com/766803/diff/1/8#newcode50 user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java:50: new ReferenceMap(ReferenceMap.WEAK, ReferenceMap.WEAK); On 2010/08/19 01:04:10, scottb wrote:
Or make it a ThreadLocal, and don't key it off the TypeOracle at all.
Yep, done. http://gwt-code-reviews.appspot.com/766803/diff/1/8#newcode77 user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java:77: protected AbstractResourceContext( On 2010/08/19 01:04:10, scottb wrote:
Pplease avoid mixing "format" changes in with a semantic patch--
you've got a
ton of them in this patch. If something badly needs reformatting, we
do it in a
separate change. That being said, I'm pretty sure your format
settings are off.
Did you configure them according to the instructions in
"eclipse/README.txt"? This particular file I think was messed up by being open in another editor. I've addressed this in another comment but I changed my Eclipse settings in response to a previous review. http://gwt-code-reviews.appspot.com/766803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
