The patch is missing a test that we discussed -- the test posts a
sequence of edits and verifies that sane results are returned.


http://gwt-code-reviews.appspot.com/880801/diff/3001/4001
File user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java
(left):

http://gwt-code-reviews.appspot.com/880801/diff/3001/4001#oldcode149
user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java:149: }
Why was this conditional removed?

http://gwt-code-reviews.appspot.com/880801/diff/3001/4001#oldcode156
user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java:156:
toCommit.fire(receiver);
where is the fire call now?

http://gwt-code-reviews.appspot.com/880801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to