Fair enough re: the test.

http://gwt-code-reviews.appspot.com/880801/diff/3001/4001
File user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java
(left):

http://gwt-code-reviews.appspot.com/880801/diff/3001/4001#oldcode149
user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java:149: }
Because we can receive no errors that are not related to our request,
and because stableId is only set for creates.

On 2010/09/15 08:15:53, amitmanjhi wrote:
Why was this conditional removed?

http://gwt-code-reviews.appspot.com/880801/diff/3001/4001#oldcode156
user/src/com/google/gwt/app/place/AbstractProxyEditActivity.java:156:
toCommit.fire(receiver);
On 2010/09/15 08:15:53, amitmanjhi wrote:
where is the fire call now?

Line 114. The receiver variable was inlined, it served no purpose.

http://gwt-code-reviews.appspot.com/880801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to