Here's the spec: https://wave.google.com/wave/waveref/googlewave.com/w+UnRfCRd2C
On Wed, Sep 15, 2010 at 7:27 PM, Ray Ryan <[email protected]> wrote: > Whoa, what's going on here? We don't want stack traces going from the > server to the client, just the other direction. Amit's design explicitly > does not call for sending stack traces back. > > Did he show you the design wave? > > > On Wed, Sep 15, 2010 at 6:42 PM, <[email protected]> wrote: > >> >> http://gwt-code-reviews.appspot.com/886801/diff/3001/4005 >> File user/src/com/google/gwt/requestfactory/shared/Receiver.java >> (right): >> >> http://gwt-code-reviews.appspot.com/886801/diff/3001/4005#newcode57 >> user/src/com/google/gwt/requestfactory/shared/Receiver.java:57: } >> The formatting in this class has degraded. >> >> http://gwt-code-reviews.appspot.com/886801/diff/3001/4006 >> File user/src/com/google/gwt/requestfactory/shared/ServerFailure.java >> (right): >> >> http://gwt-code-reviews.appspot.com/886801/diff/3001/4006#newcode47 >> user/src/com/google/gwt/requestfactory/shared/ServerFailure.java:47: >> public String getStackTraceString() { >> Server-side stack traces do not belong on the client because they are a >> significant source of information leakage. >> >> http://gwt-code-reviews.appspot.com/886801/diff/3001/4006#newcode51 >> user/src/com/google/gwt/requestfactory/shared/ServerFailure.java:51: >> public String getExceptionType() { >> This is also an information leak (although a much smaller one since raw >> type names are used pervasively in the transport layer). What hook is >> available to allow the developer to control how error messages are >> created? >> >> http://gwt-code-reviews.appspot.com/886801/diff/3001/4007 >> File >> >> user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java >> (right): >> >> http://gwt-code-reviews.appspot.com/886801/diff/3001/4007#newcode450 >> >> user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:450: >> assertEquals(UnsupportedOperationException.class.getName(), >> This assertion should fail when class metadata has been disabled. Did >> you run the full set of smoke tests? >> >> http://gwt-code-reviews.appspot.com/886801/diff/3001/4007#newcode592 >> >> user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:592: >> >> Whitespace diff. >> >> http://gwt-code-reviews.appspot.com/886801/diff/3001/4009 >> File user/test/com/google/gwt/requestfactory/server/SimpleFoo.java >> (right): >> >> http://gwt-code-reviews.appspot.com/886801/diff/3001/4009#newcode104 >> user/test/com/google/gwt/requestfactory/server/SimpleFoo.java:104: >> Whitespace. >> >> >> http://gwt-code-reviews.appspot.com/886801/show >> >> -- >> http://groups.google.com/group/Google-Web-Toolkit-Contributors >> > > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
