Oops! I forgot to add RequestFactoryExceptionHandlerTest to RequestFactorySuite
http://gwt-code-reviews.appspot.com/886801/diff/28001/15008 File user/src/com/google/gwt/requestfactory/server/ExceptionHandler.java (right): http://gwt-code-reviews.appspot.com/886801/diff/28001/15008#newcode30 user/src/com/google/gwt/requestfactory/server/ExceptionHandler.java:30: ServerFailure asServerFailure(Throwable throwable); On 2010/09/17 13:10:31, bobv wrote:
Rename "as" to "create". The "as" verb is usually used when one type
is posing
as another (e.g. IsWidget).
Done. http://gwt-code-reviews.appspot.com/886801/diff/28001/15009 File user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java (right): http://gwt-code-reviews.appspot.com/886801/diff/28001/15009#newcode836 user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:836: exceptionMessage.put("trace", failure.getStackTraceString()); On 2010/09/17 13:10:31, bobv wrote:
You've written the client-side implementation defensively, so you
could drop
null or zero-length strings from the payload.
Done. http://gwt-code-reviews.appspot.com/886801/diff/28001/15012 File user/src/com/google/gwt/requestfactory/shared/Receiver.java (right): http://gwt-code-reviews.appspot.com/886801/diff/28001/15012#newcode39 user/src/com/google/gwt/requestfactory/shared/Receiver.java:39: + ((!exceptionType.isEmpty() && !message.isEmpty()) ? ": " : "") On 2010/09/17 13:10:31, bobv wrote:
isEmpty() is a 1.6-ism.
Done. http://gwt-code-reviews.appspot.com/886801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
