LGTM if you have verified it works with the Linux .so's in the CRX and a
couple of nits.


http://gwt-code-reviews.appspot.com/1036801/diff/1/3
File plugins/npapi/manifest-template.json (right):

http://gwt-code-reviews.appspot.com/1036801/diff/1/3#newcode24
plugins/npapi/manifest-template.json:24: { "path":
"Darwin-gcc3/gwtDev.plugin", "public": true }
Are you sure this works when the Linux .so is included?

When I tried before, on the Mac it would try and load the Linux .so and
fail, and never try to load the Darwin version.

Is it simply having the directory with the plist file that fixes that?

http://gwt-code-reviews.appspot.com/1036801/diff/1/4
File
plugins/npapi/prebuilt/gwt-dev-plugin/Darwin-gcc3/gwtDev.plugin/Contents/Info.plist
(right):

http://gwt-code-reviews.appspot.com/1036801/diff/1/4#newcode30
plugins/npapi/prebuilt/gwt-dev-plugin/Darwin-gcc3/gwtDev.plugin/Contents/Info.plist:30:
<string>Plugin to allow debugging of GWT applications in Out of Process
Hosted Mode (OOPHM)</string>
Should probably change this to DevMode

http://gwt-code-reviews.appspot.com/1036801/diff/1/5
File plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json (right):

http://gwt-code-reviews.appspot.com/1036801/diff/1/5#newcode3
plugins/npapi/prebuilt/gwt-dev-plugin/manifest.json:3: "version":
"9119",
Shouldn't this be 1.0.9119?

http://gwt-code-reviews.appspot.com/1036801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to