I replaced the JSNI get*Touch() method return types, which were Touch[],
to be JsArray<Touch> instead. I hadn't run into any issues with Touch[]
during testing, as there's no development mode on Android / iOS to trip
you up.




http://gwt-code-reviews.appspot.com/867801/diff/12001/13004
File user/src/com/google/gwt/dom/client/Touch.java (right):

http://gwt-code-reviews.appspot.com/867801/diff/12001/13004#newcode25
user/src/com/google/gwt/dom/client/Touch.java:25: public class Touch
extends JavaScriptObject {
I started out without the DOMImpl silliness, but then decided that
consistency and being able to predictably find all the DOM accessors in
the DOMImpl classes had some benefit.

http://gwt-code-reviews.appspot.com/867801/diff/12001/13028
File user/src/com/google/gwt/event/dom/client/TouchEvent.java (right):

http://gwt-code-reviews.appspot.com/867801/diff/12001/13028#newcode24
user/src/com/google/gwt/event/dom/client/TouchEvent.java:24: * @see
http://developer.apple.com/library/safari/documentation/UserExperience/Reference/TouchEventClassReference/TouchEvent/TouchEvent.html
Can't break up the URL :(

http://gwt-code-reviews.appspot.com/867801/diff/12001/13036
File user/src/com/google/gwt/user/client/impl/DOMImplStandard.java
(right):

http://gwt-code-reviews.appspot.com/867801/diff/12001/13036#newcode209
user/src/com/google/gwt/user/client/impl/DOMImplStandard.java:209:
$wnd.addEventListener('touchcanel',
@com.google.gwt.user.client.impl.DOMImplStandard::dispatchCapturedMouseEvent,
true);
On 2010/11/03 21:26:00, pdr wrote:
typo: 'touchcanel' should be 'touchcancel'

Done. Thanks!

http://gwt-code-reviews.appspot.com/867801/diff/12001/13041
File user/test/com/google/gwt/user/client/GestureEventSinkTest.java
(right):

http://gwt-code-reviews.appspot.com/867801/diff/12001/13041#newcode57
user/test/com/google/gwt/user/client/GestureEventSinkTest.java:57:
assertNotSame(0, Event.ONTOUCHCHANGE);
On 2010/11/03 21:26:00, pdr wrote:
Should be Event.ONTOUCHCANCEL, not ONTOUCHCHANGE

Done.

http://gwt-code-reviews.appspot.com/867801/diff/12001/13041#newcode79
user/test/com/google/gwt/user/client/GestureEventSinkTest.java:79:
On 2010/11/03 21:26:00, pdr wrote:
Formatting (spaces)

Done.

http://gwt-code-reviews.appspot.com/867801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to