http://gwt-code-reviews.appspot.com/1116801/diff/1/6 File plugins/ie/installer/build.cmd (right):
http://gwt-code-reviews.appspot.com/1116801/diff/1/6#newcode8 plugins/ie/installer/build.cmd:8: echo IMPORTANT: Make sure "%~dp0oophm.wsx" is checked out and writable! On 2010/11/18 16:17:54, conroy wrote:
Rather than just blindly warning about this, why not test and error if
the files
aren't writable?
Also, s/prebuild/prebuilt
Done. http://gwt-code-reviews.appspot.com/1116801/diff/1/11 File plugins/ie/installer/wix/candle.exe.config (right): http://gwt-code-reviews.appspot.com/1116801/diff/1/11#newcode3 plugins/ie/installer/wix/candle.exe.config:3: Copyright (c) Microsoft Corporation. All rights reserved. On 2010/11/18 16:17:54, conroy wrote:
does this msft copyright need to be here?
if anything, shouldn't all these new files be getting the standard GWT
copyright
notice?
this a MS tool licensed to OS. I believe removing the copyright might be an issue. http://gwt-code-reviews.appspot.com/1116801/diff/1/15 File plugins/ie/oophm/oophm/dllmain.cpp (right): http://gwt-code-reviews.appspot.com/1116801/diff/1/15#newcode36 plugins/ie/oophm/oophm/dllmain.cpp:36: AllowDialog::setHInstance(hInstance); On 2010/11/18 16:17:54, conroy wrote:
indentation looks off here
Done. http://gwt-code-reviews.appspot.com/1116801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
