LGTM with nits. I assume you will checking the prebuilt binaries separately?
http://gwt-code-reviews.appspot.com/1116801/diff/9001/10004 File plugins/ie/installer/README.txt (right): http://gwt-code-reviews.appspot.com/1116801/diff/9001/10004#newcode16 plugins/ie/installer/README.txt:16: 4) Test the installation. Yes, make sure it works on x86, x64, it cleans the registry and folder upon uninstall, etc. Should stick to 80 columns in the text files. http://gwt-code-reviews.appspot.com/1116801/diff/9001/10005 File plugins/ie/installer/build.cmd (right): http://gwt-code-reviews.appspot.com/1116801/diff/9001/10005#newcode28 plugins/ie/installer/build.cmd:28: %~dp0wix\heat.exe file %BINARY_DIR%\%BINARY_FILE% -v -nologo -gg -g1 -dr INSTALLDIR -generate components -directoryid ff -cg oophmDll -out %~dp0oophm.wxs -var var.binDir What are the %~dp0* references? http://gwt-code-reviews.appspot.com/1116801/diff/9001/10009 File plugins/ie/installer/oophm.wxs (right): http://gwt-code-reviews.appspot.com/1116801/diff/9001/10009#newcode2 plugins/ie/installer/oophm.wxs:2: <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi";> Maybe this file should be renamed to DevModePlugin.wxs or something like that -- while it isn't worth it to clean up existing references to OOPHM in names, we probably shouldn't add any more. You should also get jlabanca to look over the WIX files, since he got that working initially. http://gwt-code-reviews.appspot.com/1116801/diff/9001/10014 File plugins/ie/oophm/oophm/dllmain.cpp (right): http://gwt-code-reviews.appspot.com/1116801/diff/9001/10014#newcode34 plugins/ie/oophm/oophm/dllmain.cpp:34: DisableThreadLibraryCalls(hInstance); Use spaces instead of tabs on these lines. http://gwt-code-reviews.appspot.com/1116801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
