http://gwt-code-reviews.appspot.com/1162801/diff/1/2 File user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java (right):
http://gwt-code-reviews.appspot.com/1162801/diff/1/2#newcode31 user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java:31: * Adds support to the ServiceLayer chain for using {...@link Locator} helper and {...@link ServiceLocator} http://gwt-code-reviews.appspot.com/1162801/diff/1/3 File user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java (right): http://gwt-code-reviews.appspot.com/1162801/diff/1/3#newcode181 user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java:181: if (foundLocator || foundProxy || foundService || foundServiceLocator) { Can one interface have both @ProxyFor and @Service? If so, what happens w/redundant @Locator and @ServiceLocator annotations? http://gwt-code-reviews.appspot.com/1162801/diff/1/14 File user/test/com/google/gwt/requestfactory/shared/InstanceServiceRequest.java (right): http://gwt-code-reviews.appspot.com/1162801/diff/1/14#newcode24 user/test/com/google/gwt/requestfactory/shared/InstanceServiceRequest.java:24: @Service(InstanceService.class) Can InstanceService be an interface? Very common case. http://gwt-code-reviews.appspot.com/1162801/diff/1/14#newcode25 user/test/com/google/gwt/requestfactory/shared/InstanceServiceRequest.java:25: @ServiceLocatorFor(InstanceServiceLocator.class) ServiceLocatorFor name is confusing. Makes it sound like InstanceServiceRequest is the locator. @ServiceLocator(Class) and @ServiceLocatorName(String)? What are the corresponding names for Locator? Shouldn't you be testing service that mixes instance and static methods, since you made a point of supporting it? http://gwt-code-reviews.appspot.com/1162801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
