http://gwt-code-reviews.appspot.com/1162801/diff/1/2
File
user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java
(right):
http://gwt-code-reviews.appspot.com/1162801/diff/1/2#newcode31
user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java:31:
* Adds support to the ServiceLayer chain for using {...@link Locator}
helper
On 2010/11/30 17:17:40, rjrjr wrote:
and {...@link ServiceLocator}
Done.
http://gwt-code-reviews.appspot.com/1162801/diff/1/3
File
user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java
(right):
http://gwt-code-reviews.appspot.com/1162801/diff/1/3#newcode181
user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java:181:
if (foundLocator || foundProxy || foundService || foundServiceLocator) {
On 2010/11/30 17:17:40, rjrjr wrote:
Can one interface have both @ProxyFor and @Service? If so, what
happens
w/redundant @Locator and @ServiceLocator annotations?
Added a check for redundant annotations.
http://gwt-code-reviews.appspot.com/1162801/diff/1/14
File
user/test/com/google/gwt/requestfactory/shared/InstanceServiceRequest.java
(right):
http://gwt-code-reviews.appspot.com/1162801/diff/1/14#newcode24
user/test/com/google/gwt/requestfactory/shared/InstanceServiceRequest.java:24:
@Service(InstanceService.class)
On 2010/11/30 17:17:40, rjrjr wrote:
Can InstanceService be an interface? Very common case.
Done.
http://gwt-code-reviews.appspot.com/1162801/diff/1/14#newcode25
user/test/com/google/gwt/requestfactory/shared/InstanceServiceRequest.java:25:
@ServiceLocatorFor(InstanceServiceLocator.class)
On 2010/11/30 17:17:40, rjrjr wrote:
ServiceLocatorFor name is confusing. Makes it sound like
InstanceServiceRequest
is the locator.
@ServiceLocator(Class) and @ServiceLocatorName(String)? What are the
corresponding names for Locator?
The @Locator and @ServiceLocator annotations have been removed. The
data is now embedded in the @ProxyFor and @Service annotations.
Shouldn't you be testing service that mixes instance and static
methods, since
you made a point of supporting it?
There's no special code necessary to handle this.
http://gwt-code-reviews.appspot.com/1162801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
