LGTM.

Why is log4j.properties in this patch?


http://gwt-code-reviews.appspot.com/1200801/diff/3001/4002
File
samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseReportList.java
(right):

http://gwt-code-reviews.appspot.com/1200801/diff/3001/4002#newcode98
samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseReportList.java:98:

Extra blank line here?

http://gwt-code-reviews.appspot.com/1200801/diff/3001/4006
File user/src/com/google/gwt/activity/shared/Activity.java (right):

http://gwt-code-reviews.appspot.com/1200801/diff/3001/4006#newcode29
user/src/com/google/gwt/activity/shared/Activity.java:29: * this class
should not introduce non-trivial behavior.
@see IsActivity   ?

http://gwt-code-reviews.appspot.com/1200801/diff/3001/4006#newcode39
user/src/com/google/gwt/activity/shared/Activity.java:39: abstract
public String mayStop();
JLS modifier order, here and elsewhere.

http://gwt-code-reviews.appspot.com/1200801/diff/3001/4008
File user/src/com/google/gwt/activity/shared/IsActivity.java (right):

http://gwt-code-reviews.appspot.com/1200801/diff/3001/4008#newcode22
user/src/com/google/gwt/activity/shared/IsActivity.java:22: Activity
asActivity();
doc?

http://gwt-code-reviews.appspot.com/1200801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to