log4j thing is there because the lack of it causes an insane amount of console noise, and I keep forgetting to add it.
http://gwt-code-reviews.appspot.com/1200801/diff/3001/4002 File samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseReportList.java (right): http://gwt-code-reviews.appspot.com/1200801/diff/3001/4002#newcode98 samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseReportList.java:98: On 2010/12/08 23:27:43, bobv wrote:
Extra blank line here?
Done. http://gwt-code-reviews.appspot.com/1200801/diff/3001/4006 File user/src/com/google/gwt/activity/shared/Activity.java (right): http://gwt-code-reviews.appspot.com/1200801/diff/3001/4006#newcode29 user/src/com/google/gwt/activity/shared/Activity.java:29: * this class should not introduce non-trivial behavior. On 2010/12/08 23:27:43, bobv wrote:
@see IsActivity ?
Done. http://gwt-code-reviews.appspot.com/1200801/diff/3001/4006#newcode39 user/src/com/google/gwt/activity/shared/Activity.java:39: abstract public String mayStop(); On 2010/12/08 23:27:43, bobv wrote:
JLS modifier order, here and elsewhere.
Done. http://gwt-code-reviews.appspot.com/1200801/diff/3001/4008 File user/src/com/google/gwt/activity/shared/IsActivity.java (right): http://gwt-code-reviews.appspot.com/1200801/diff/3001/4008#newcode22 user/src/com/google/gwt/activity/shared/IsActivity.java:22: Activity asActivity(); On 2010/12/08 23:27:43, bobv wrote:
doc?
Done. http://gwt-code-reviews.appspot.com/1200801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
