LG, just nits.
http://gwt-code-reviews.appspot.com/1215801/diff/1/4 File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java (right): http://gwt-code-reviews.appspot.com/1215801/diff/1/4#newcode231 dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:231: eventsByGeneratorType.put("com.google.gwt.resources.rebind.context.InlineClientBundleGenerator", CompilerEventType.GENERATOR_CLIENT_BUNDLE); I thought it was possible to create new event types on the fly. Maybe we should just do that for every generator? I get that this is very practical, feels slightly hacky tho. :) http://gwt-code-reviews.appspot.com/1215801/diff/7001/8004 File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java (right): http://gwt-code-reviews.appspot.com/1215801/diff/7001/8004#newcode1255 dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java:1255: event.end(); Try/finally? I think the call can fail, if say the comm channel drops. http://gwt-code-reviews.appspot.com/1215801/diff/7001/8006 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/CompilerEventType.java (right): http://gwt-code-reviews.appspot.com/1215801/diff/7001/8006#newcode38 dev/core/src/com/google/gwt/dev/util/log/speedtracer/CompilerEventType.java:38: GENERATOR_OTHER("Generator (Other)", "Red"), // Feels kind of ugh to include these here. I'm starting to think just creating event types on the fly for generator types is the way to go. Could all be done inside StandardGeneratorContext. http://gwt-code-reviews.appspot.com/1215801/diff/7001/8009 File tools/api-checker/config/gwt21_22userApi.conf (right): http://gwt-code-reviews.appspot.com/1215801/diff/7001/8009#newcode123 tools/api-checker/config/gwt21_22userApi.conf:123: com.google.gwt.user.client.rpc.core.java.util.Collections.SingletonList_CustomFieldSerializer::concreteType() RETURN_TYPE_ERROR Should we just exclude that whole package? This is a non-user-facing implementation detail. http://gwt-code-reviews.appspot.com/1215801/diff/7001/8017 File user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java (right): http://gwt-code-reviews.appspot.com/1215801/diff/7001/8017#newcode327 user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java:327: * Writes a method to produce a map of type string -> {...@link TypeHandler} map of type string -> type handler class name? http://gwt-code-reviews.appspot.com/1215801/diff/7001/8017#newcode444 user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java:444: * Writes a method to produce a map of class to type string for Java. also needs update http://gwt-code-reviews.appspot.com/1215801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
