http://gwt-code-reviews.appspot.com/1215801/diff/1/4 File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java (right):
http://gwt-code-reviews.appspot.com/1215801/diff/1/4#newcode231 dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:231: eventsByGeneratorType.put("com.google.gwt.resources.rebind.context.InlineClientBundleGenerator", CompilerEventType.GENERATOR_CLIENT_BUNDLE); On 2010/12/14 22:11:56, scottb wrote:
I thought it was possible to create new event types on the fly. Maybe
we should
just do that for every generator? I get that this is very practical,
feels
slightly hacky tho. :)
I don't think that's practical. For example, I'm doing things like manually categorizing groups of generators together. (For example, deRPC + RPC, and all i18n generators). You'd also have to synthesize reasonable colors for these things. Again, I think we can improve our tooling instead and make this go away. http://gwt-code-reviews.appspot.com/1215801/diff/7001/8004 File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java (right): http://gwt-code-reviews.appspot.com/1215801/diff/7001/8004#newcode1255 dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java:1255: event.end(); On 2010/12/14 22:11:56, scottb wrote:
Try/finally? I think the call can fail, if say the comm channel
drops. Done. http://gwt-code-reviews.appspot.com/1215801/diff/7001/8006 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/CompilerEventType.java (right): http://gwt-code-reviews.appspot.com/1215801/diff/7001/8006#newcode38 dev/core/src/com/google/gwt/dev/util/log/speedtracer/CompilerEventType.java:38: GENERATOR_OTHER("Generator (Other)", "Red"), // On 2010/12/14 22:11:56, scottb wrote:
Feels kind of ugh to include these here. I'm starting to think just
creating
event types on the fly for generator types is the way to go. Could
all be done
inside StandardGeneratorContext.
FWIW, I did actually try this and it turned out to be actively worse. http://gwt-code-reviews.appspot.com/1215801/diff/7001/8009 File tools/api-checker/config/gwt21_22userApi.conf (right): http://gwt-code-reviews.appspot.com/1215801/diff/7001/8009#newcode123 tools/api-checker/config/gwt21_22userApi.conf:123: com.google.gwt.user.client.rpc.core.java.util.Collections.SingletonList_CustomFieldSerializer::concreteType() RETURN_TYPE_ERROR On 2010/12/14 22:11:56, scottb wrote:
Should we just exclude that whole package? This is a non-user-facing implementation detail.
Done. http://gwt-code-reviews.appspot.com/1215801/diff/7001/8017 File user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java (right): http://gwt-code-reviews.appspot.com/1215801/diff/7001/8017#newcode327 user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java:327: * Writes a method to produce a map of type string -> {...@link TypeHandler} On 2010/12/14 22:11:56, scottb wrote:
map of type string -> type handler class name?
Done. http://gwt-code-reviews.appspot.com/1215801/diff/7001/8017#newcode444 user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java:444: * Writes a method to produce a map of class to type string for Java. On 2010/12/14 22:11:56, scottb wrote:
also needs update
Done. http://gwt-code-reviews.appspot.com/1215801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
