http://gwt-code-reviews.appspot.com/1385810/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (right):
http://gwt-code-reviews.appspot.com/1385810/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java#newcode257 dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java:257: for (CompilationUnit unit : resultUnits) { DEBUG or TRACE? The warning message suggests setting logLevel to DEBUG, but the actual logging here is for TRACE? http://gwt-code-reviews.appspot.com/1385810/diff/1/dev/core/src/com/google/gwt/dev/javac/ProblemReporter.java File dev/core/src/com/google/gwt/dev/javac/ProblemReporter.java (right): http://gwt-code-reviews.appspot.com/1385810/diff/1/dev/core/src/com/google/gwt/dev/javac/ProblemReporter.java#newcode53 dev/core/src/com/google/gwt/dev/javac/ProblemReporter.java:53: javadoc? http://gwt-code-reviews.appspot.com/1385810/diff/1/dev/core/src/com/google/gwt/dev/javac/ProblemReporter.java#newcode157 dev/core/src/com/google/gwt/dev/javac/ProblemReporter.java:157: // For Object in particular, there's a special warning. Is this comment here for Object, or for java.lang in general? Or is it for the "else if" clause above? Above we have a message for anything that's not java.lang.Object, and below we have something for anything that's java.lang.*. Can it be a bit more clear, or maybe more comments to explain? http://gwt-code-reviews.appspot.com/1385810/diff/1/dev/core/src/com/google/gwt/dev/javac/ProblemReporter.java#newcode158 dev/core/src/com/google/gwt/dev/javac/ProblemReporter.java:158: // all three of these cases do the same thing, so can collapse into a single compound if(.. || .. || ..) http://gwt-code-reviews.appspot.com/1385810/diff/1/dev/core/src/com/google/gwt/dev/javac/ProblemReporter.java#newcode212 dev/core/src/com/google/gwt/dev/javac/ProblemReporter.java:212: * @param maxLogLevel The log level for logging errors. Since the JDT compile Will this still be true if we eventually get rid of the second compilation? Maybe change to say something along the lines of allow variable logLevel to support support case where we have a multiple pass compilation, etc. http://gwt-code-reviews.appspot.com/1385810/diff/1/dev/core/src/com/google/gwt/dev/javac/ProblemReporter.java#newcode232 dev/core/src/com/google/gwt/dev/javac/ProblemReporter.java:232: * Need a second "logger" after "@param logger" http://gwt-code-reviews.appspot.com/1385810/diff/1/dev/core/src/com/google/gwt/dev/javac/ProblemReporter.java#newcode238 dev/core/src/com/google/gwt/dev/javac/ProblemReporter.java:238: * @param errorLogLevel The log level for logging errors. Since the JDT change to something like "since compile can run multiple times...." http://gwt-code-reviews.appspot.com/1385810/diff/1/user/src/com/google/gwt/http/client/RequestBuilder.java File user/src/com/google/gwt/http/client/RequestBuilder.java (right): http://gwt-code-reviews.appspot.com/1385810/diff/1/user/src/com/google/gwt/http/client/RequestBuilder.java#newcode50 user/src/com/google/gwt/http/client/RequestBuilder.java:50: } white space? http://gwt-code-reviews.appspot.com/1385810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
