LGTM, just nits.
http://gwt-code-reviews.appspot.com/1385810/diff/8012/dev/core/src/com/google/gwt/dev/cfg/DeferredBindingQuery.java File dev/core/src/com/google/gwt/dev/cfg/DeferredBindingQuery.java (right): http://gwt-code-reviews.appspot.com/1385810/diff/8012/dev/core/src/com/google/gwt/dev/cfg/DeferredBindingQuery.java#newcode49 dev/core/src/com/google/gwt/dev/cfg/DeferredBindingQuery.java:49: TypeOracle typeOracle, String testType, CompilationState compilationState) { Nit, could remove the typeOracle param and field, since it's just compState.getTypeOracle(). http://gwt-code-reviews.appspot.com/1385810/diff/8012/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java File dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java (right): http://gwt-code-reviews.appspot.com/1385810/diff/8012/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java#newcode74 dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java:74: while (toVisit.peek() != null) { !toVisit.isEmpty() http://gwt-code-reviews.appspot.com/1385810/diff/8012/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java#newcode107 dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java:107: final Map<String, CompilationUnit> unitMap) { Since this method and logMissingTypeErrorWithHints() are both public, they should probably either both take a CompilationState or both take the unit map. for consistentcy. http://gwt-code-reviews.appspot.com/1385810/diff/8012/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java#newcode163 dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java:163: String typeName) { private? http://gwt-code-reviews.appspot.com/1385810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
