I asked Phil to go ahead and note what he found just so we could
verify that the formatter is doing what we want.

(can't edit rietveld right now...)

The 4 vs 2 space issue is spelled out in the "Making GWT Better" page
under indentation.
  http://code.google.com/webtoolkit/makinggwtbetter.html#codestyle
So I don't think anything's wrong there.

The breaking of the statement in the middle is not how most of us
would format that statement by hand, but there doesn't seem to be a
good way to tell the formatter to use builder formatting when the API
is  using builder pattern and something else when it isn't.  (How is
the formatter supposed to tell the difference?)


On Tue, Apr 5, 2011 at 8:35 PM, Ray Ryan <rj...@google.com> wrote:
> I don't think it's reasonable to ask Eric to tweak the auto formatter. We
> had that conversation already. He's just doing the same thing we have
> eclipse configured to do, right?
>
> I can't look for real right now. Did you really find something aggregious?
>
> On Apr 5, 2011 9:34 AM, <p...@google.com> wrote:
>



-- 
Eric Z. Ayers
Google Web Toolkit, Atlanta, GA USA

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to