http://gwt-code-reviews.appspot.com/1425811/diff/1/user/src/com/google/gwt/uibinder/elementparsers/HtmlInterpreter.java File user/src/com/google/gwt/uibinder/elementparsers/HtmlInterpreter.java (right):
http://gwt-code-reviews.appspot.com/1425811/diff/1/user/src/com/google/gwt/uibinder/elementparsers/HtmlInterpreter.java#newcode91 user/src/com/google/gwt/uibinder/elementparsers/HtmlInterpreter.java:91: return writer.tokenForSafeHtmlExpression( I think instead you want to use the tokenForExpression method that Rafa just added. http://gwt-code-reviews.appspot.com/1425811/diff/1/user/test/com/google/gwt/uibinder/elementparsers/AbsolutePanelParserTest.java File user/test/com/google/gwt/uibinder/elementparsers/AbsolutePanelParserTest.java (right): http://gwt-code-reviews.appspot.com/1425811/diff/1/user/test/com/google/gwt/uibinder/elementparsers/AbsolutePanelParserTest.java#newcode98 user/test/com/google/gwt/uibinder/elementparsers/AbsolutePanelParserTest.java:98: b.append(" <g:Label/>"); This is a bit disturbing. Why did it fix it? Or is the real question why did it pass in the first place? http://gwt-code-reviews.appspot.com/1425811/diff/1/user/test/com/google/gwt/uibinder/test/LazyWidgetBuilderTest.gwt.xml File user/test/com/google/gwt/uibinder/test/LazyWidgetBuilderTest.gwt.xml (right): http://gwt-code-reviews.appspot.com/1425811/diff/1/user/test/com/google/gwt/uibinder/test/LazyWidgetBuilderTest.gwt.xml#newcode18 user/test/com/google/gwt/uibinder/test/LazyWidgetBuilderTest.gwt.xml:18: <entry-point class="com.google.gwt.uibinder.test.client.LazyWidgetBuilderTest" /> I don't think you need the entry-point http://gwt-code-reviews.appspot.com/1425811/diff/1/user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuildersTest.java File user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuildersTest.java (right): http://gwt-code-reviews.appspot.com/1425811/diff/1/user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuildersTest.java#newcode52 user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuildersTest.java:52: assertEquals("Hello Bob", domUi.div.getInnerHTML()); check for the <b>, make sure it didn't get escaped. http://gwt-code-reviews.appspot.com/1425811/diff/1/user/test/com/google/gwt/uibinder/test/client/SafeHtmlObject.java File user/test/com/google/gwt/uibinder/test/client/SafeHtmlObject.java (right): http://gwt-code-reviews.appspot.com/1425811/diff/1/user/test/com/google/gwt/uibinder/test/client/SafeHtmlObject.java#newcode28 user/test/com/google/gwt/uibinder/test/client/SafeHtmlObject.java:28: return "Hello " + name; Should put some markup in here, so we can test for improper escaping. "Hello <b>" + name + "</b>." http://gwt-code-reviews.appspot.com/1425811/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors