http://gwt-code-reviews.appspot.com/1425811/diff/1/user/src/com/google/gwt/uibinder/elementparsers/HtmlInterpreter.java File user/src/com/google/gwt/uibinder/elementparsers/HtmlInterpreter.java (right):
http://gwt-code-reviews.appspot.com/1425811/diff/1/user/src/com/google/gwt/uibinder/elementparsers/HtmlInterpreter.java#newcode91 user/src/com/google/gwt/uibinder/elementparsers/HtmlInterpreter.java:91: return writer.tokenForSafeHtmlExpression( On 2011/04/27 19:29:58, rjrjr wrote:
I think instead you want to use the tokenForExpression method that
Rafa just
added.
Done. http://gwt-code-reviews.appspot.com/1425811/diff/1/user/test/com/google/gwt/uibinder/elementparsers/AbsolutePanelParserTest.java File user/test/com/google/gwt/uibinder/elementparsers/AbsolutePanelParserTest.java (right): http://gwt-code-reviews.appspot.com/1425811/diff/1/user/test/com/google/gwt/uibinder/elementparsers/AbsolutePanelParserTest.java#newcode98 user/test/com/google/gwt/uibinder/elementparsers/AbsolutePanelParserTest.java:98: b.append(" <g:Label/>"); On 2011/04/27 19:29:58, rjrjr wrote:
This is a bit disturbing. Why did it fix it? Or is the real question
why did it
pass in the first place?
Sorry - I thought you saw my comment on the other review thread - I have no idea why this didn't work for TextBox and was hoping that perhaps you would have some inkling? http://gwt-code-reviews.appspot.com/1425811/diff/1/user/test/com/google/gwt/uibinder/test/LazyWidgetBuilderTest.gwt.xml File user/test/com/google/gwt/uibinder/test/LazyWidgetBuilderTest.gwt.xml (right): http://gwt-code-reviews.appspot.com/1425811/diff/1/user/test/com/google/gwt/uibinder/test/LazyWidgetBuilderTest.gwt.xml#newcode18 user/test/com/google/gwt/uibinder/test/LazyWidgetBuilderTest.gwt.xml:18: <entry-point class="com.google.gwt.uibinder.test.client.LazyWidgetBuilderTest" /> On 2011/04/27 19:29:58, rjrjr wrote:
I don't think you need the entry-point
Done. http://gwt-code-reviews.appspot.com/1425811/diff/1/user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuildersTest.java File user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuildersTest.java (right): http://gwt-code-reviews.appspot.com/1425811/diff/1/user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuildersTest.java#newcode52 user/test/com/google/gwt/uibinder/test/client/LazyWidgetBuildersTest.java:52: assertEquals("Hello Bob", domUi.div.getInnerHTML()); On 2011/04/27 19:29:58, rjrjr wrote:
check for the <b>, make sure it didn't get escaped.
Done. http://gwt-code-reviews.appspot.com/1425811/diff/1/user/test/com/google/gwt/uibinder/test/client/SafeHtmlObject.java File user/test/com/google/gwt/uibinder/test/client/SafeHtmlObject.java (right): http://gwt-code-reviews.appspot.com/1425811/diff/1/user/test/com/google/gwt/uibinder/test/client/SafeHtmlObject.java#newcode28 user/test/com/google/gwt/uibinder/test/client/SafeHtmlObject.java:28: return "Hello " + name; On 2011/04/27 19:29:58, rjrjr wrote:
Should put some markup in here, so we can test for improper escaping.
"Hello
<b>" + name + "</b>."
Done. http://gwt-code-reviews.appspot.com/1425811/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors