On 2011/05/06 19:58:54, Josh Humphries wrote:

http://gwt-code-reviews.appspot.com/1427807/diff/15015/dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
File
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
(right):


http://gwt-code-reviews.appspot.com/1427807/diff/15015/dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java#newcode71

dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:71:
private static final boolean logThreadCpuTime = !logProcessCpuTime
Like so? (see patchset 7)

On 2011/05/06 19:03:11, tobyr wrote:
> I'd rather see a test that throws an exception if both are set. That
way it's
> not a silent "failure".

LGTM

http://gwt-code-reviews.appspot.com/1427807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to