2011/5/26 Eric Ayers <zun...@google.com>:
> Hi again,
>
> Can you point out any of places where you saw this assumption? The
> last time I was mucking around with binary type names I was told not
> to assume that $ could not appear in source names, so it might be
> unintentional.
Hi Eric,
The problematic place for me is ReplaceBindings.java, lines 154-155:
// Rebinds are always on a source type name.
String reqType = type.getName().replace('$', '.');
Naive grep shows a few more such places:
mac-grek:dev grek$ find . -name *.java | xargs grep "replace('$', '.')"
./core/src/com/google/gwt/dev/javac/AnnotationProxyFactory.java:
String qualifiedSourceName = annotationClass.getName().replace('$',
'.');
./core/src/com/google/gwt/dev/javac/JsniChecker.java: String
className = jsniRef.className().replace('$', '.');
./core/src/com/google/gwt/dev/jjs/ast/JGwtCreate.java: return
type.getName().replace('$', '.');
./core/src/com/google/gwt/dev/jjs/ast/JProgram.java: String
srcTypeName = qualifiedBinaryOrSourceName.replace('$', '.');
./core/src/com/google/gwt/dev/jjs/ast/JProgram.java: String
srcTypeName = qualifiedBinaryName.replace('$', '.');
./core/src/com/google/gwt/dev/jjs/impl/ReplaceRebinds.java: String
reqType = type.getName().replace('$', '.');
./core/src/com/google/gwt/dev/shell/CompilingClassLoader.java:
sourceName = sourceName.replace('$', '.');
./core/src/com/google/gwt/dev/util/TypeInfo.java: return
type.getName().replace('$', '.');
Is this something that can be refactored?
--
Grzegorz Kossakowski
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
