http://gwt-code-reviews.appspot.com/1450806/diff/3002/dev/core/src/com/google/gwt/core/ext/GeneratorContext.java
File dev/core/src/com/google/gwt/core/ext/GeneratorContext.java (right):

http://gwt-code-reviews.appspot.com/1450806/diff/3002/dev/core/src/com/google/gwt/core/ext/GeneratorContext.java#newcode34
dev/core/src/com/google/gwt/core/ext/GeneratorContext.java:34: * likely
to succeed.
Why is the argument a string rather than, say, JClassType?

Wouldn't the second sentence would be more accurate as: "is likely to
succeed for a type with no default constructor. (Any concrete type with
a zero args constructor can be instantiated via GWT.create().)"

Also, it isn't GWT.create(sourceTypeName), the argument is a class
literal.

http://gwt-code-reviews.appspot.com/1450806/diff/3002/dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
(right):

http://gwt-code-reviews.appspot.com/1450806/diff/3002/dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java#newcode373
dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:373:
return false;
When will there be no resolver? Should the GeneratorContext javadoc say
something about this?

http://gwt-code-reviews.appspot.com/1450806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to