Eric, Ray, did you guys want to weigh in also?

http://gwt-code-reviews.appspot.com/1453810/diff/3001/dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java
File dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java (right):

http://gwt-code-reviews.appspot.com/1453810/diff/3001/dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java#newcode72
dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java:72:
I could pull it, but probably it would be better for me to leave it and
note that the contents are largely copied verbatim from
JavaToJavaScriptCompiler.  I'll do that.

http://gwt-code-reviews.appspot.com/1453810/diff/3001/dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java
File dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java (right):

http://gwt-code-reviews.appspot.com/1453810/diff/3001/dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java#newcode519
dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java:519:
assimilateUnit(cc.getUnit());
Slightly easier to debug this way, tho.  But I've gotta come back
through here anyway and finish error handling.

http://gwt-code-reviews.appspot.com/1453810/diff/3001/dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java#newcode837
dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java:837: * Main loop:
run through the queue doing deferred resolution. We could have
On 2011/06/09 19:42:24, jbrosenberg wrote:
s/but a work queues/but work queues

Done.

http://gwt-code-reviews.appspot.com/1453810/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to