http://gwt-code-reviews.appspot.com/1451818/diff/8002/user/src/com/google/gwt/core/client/ScriptInjector.java File user/src/com/google/gwt/core/client/ScriptInjector.java (right):
http://gwt-code-reviews.appspot.com/1451818/diff/8002/user/src/com/google/gwt/core/client/ScriptInjector.java#newcode73 user/src/com/google/gwt/core/client/ScriptInjector.java:73: public void inject() { On 2011/06/21 13:35:06, jlabanca wrote:
On 2011/06/21 01:30:49, zundel wrote: > On 2011/06/20 20:58:29, jlabanca wrote: > > Can this return the script element? > > I'm willing to make this change but I'm not sure what hte use case
is? Is it
> still a good thing to return the script element if its just been
removed from
> the DOM?
It would allow you to remove the script element at any time, not
necessarily
immediately after it was added. It would also allow you to add
attributes, such
as an ID, to the script element, which might be useful.
Done. http://gwt-code-reviews.appspot.com/1451818/diff/10011/user/src/com/google/gwt/core/client/ScriptInjector.java#newcode30 user/src/com/google/gwt/core/client/ScriptInjector.java:30: * new ScriptInjector.FromString(scriptBody).inject(); (Change from using new on the builder object to using a factory method.) http://gwt-code-reviews.appspot.com/1451818/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
