http://gwt-code-reviews.appspot.com/1451818/diff/5008/user/src/com/google/gwt/core/client/ScriptInjector.java File user/src/com/google/gwt/core/client/ScriptInjector.java (right):
http://gwt-code-reviews.appspot.com/1451818/diff/5008/user/src/com/google/gwt/core/client/ScriptInjector.java#newcode245 user/src/com/google/gwt/core/client/ScriptInjector.java:245: scriptElement.onload = function() { On 2011/06/21 16:46:24, jlabanca wrote:
All javascript handles should be wrapped in $entry(...) to ensure
proper reentry
into GWT code, which is essential for catching exceptions. That;s
probably why
you had trouble debugging the bug you mentioned below.
Syntax: scriptElement.onload = $entry(function() { // Put stuff here. });
Done. http://gwt-code-reviews.appspot.com/1451818/diff/5008/user/src/com/google/gwt/core/client/ScriptInjector.java#newcode250 user/src/com/google/gwt/core/client/ScriptInjector.java:250: scriptElement.onerror = function() { On 2011/06/21 16:46:24, jlabanca wrote:
Wrap in $entry
Done. http://gwt-code-reviews.appspot.com/1451818/diff/5008/user/src/com/google/gwt/core/client/ScriptInjector.java#newcode252 user/src/com/google/gwt/core/client/ScriptInjector.java:252: var ex = @com.google.gwt.core.client.CodeDownloadException::new(Ljava/lang/String;)("onerror() called."); On 2011/06/21 16:46:24, jlabanca wrote:
spaces
Done. http://gwt-code-reviews.appspot.com/1451818/diff/5008/user/src/com/google/gwt/core/client/ScriptInjector.java#newcode255 user/src/com/google/gwt/core/client/ScriptInjector.java:255: scriptElement.onreadystatechange = function() { On 2011/06/21 16:46:24, jlabanca wrote:
Wrap in $entry
Done. http://gwt-code-reviews.appspot.com/1451818/diff/5008/user/src/com/google/gwt/core/client/ScriptInjector.java#newcode281 user/src/com/google/gwt/core/client/ScriptInjector.java:281: private static void doSuccessCb(Callback<Void, Exception> callback) { On 2011/06/21 16:46:24, jlabanca wrote:
On 2011/06/21 16:31:50, zundel wrote: > I introduced a bug in my test and was pulling my hair out to debug
it before I
> added this code.
Wrap the onload/onerror functions in $entry, and GWT will forward
errors to the
UncaughtExceptionHandler. Sorry I missed that before.
Done. http://gwt-code-reviews.appspot.com/1451818/diff/5008/user/test/com/google/gwt/core/client/ScriptInjectorTest.java File user/test/com/google/gwt/core/client/ScriptInjectorTest.java (right): http://gwt-code-reviews.appspot.com/1451818/diff/5008/user/test/com/google/gwt/core/client/ScriptInjectorTest.java#newcode63 user/test/com/google/gwt/core/client/ScriptInjectorTest.java:63: public void gwtTearDown() { On 2011/06/21 16:46:24, jlabanca wrote:
I'm pretty sure gwtTearDown is protected in GWTTestCase. Probably no
reason to
make it public here.
removed. http://gwt-code-reviews.appspot.com/1451818/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors