http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/lib-gwt.sh
File maven/lib-gwt.sh (right):

http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/lib-gwt.sh#newcode87
maven/lib-gwt.sh:87: maven-deploy-file $mavenRepoUrl $mavenRepoId
"$jarExpandDir-user/gwt-user-sources.jar"
$pomDir/gwt/gwt-servlet/pom.xml sources
You're allowing the deploy attempt to continue when a maven-deploy-file
call fails. Is that intentional?

http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/lib-gwt.sh#newcode91
maven/lib-gwt.sh:91: # Remove bundled org/json classes
Wouldn't it be more robust to do all of this prepping before doing any
of the maven-deploy-file calls?

http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/lib-gwt.sh#newcode105
maven/lib-gwt.sh:105: # Clean up
Should make this an exit hook

http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/lib-maven-deploy.sh
File maven/lib-maven-deploy.sh (right):

http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/lib-maven-deploy.sh#newcode28
maven/lib-maven-deploy.sh:28: echo "WARNING: Unable to deploy
$artifactId in repo! Cannot find corresponding file!"
Shouldn't you die at this point? Or return 1 and have the caller die?

http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/poms/gwt/gwt-user/pom-template.xml
File maven/poms/gwt/gwt-user/pom-template.xml (right):

http://gwt-code-reviews.appspot.com/1520810/diff/12001/maven/poms/gwt/gwt-user/pom-template.xml#newcode20
maven/poms/gwt/gwt-user/pom-template.xml:20: </dependency>
out-dent

http://gwt-code-reviews.appspot.com/1520810/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to