http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/dom/client/BrowserEvents.java File user/src/com/google/gwt/dom/client/BrowserEvents.java (right):
http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/dom/client/BrowserEvents.java#newcode39 user/src/com/google/gwt/dom/client/BrowserEvents.java:39: public static final String FOCUSIN = "focusin"; focusin is not part of any standard and is only used in IE. I used it in CellWidgets because it is the equivalent of focus, but it bubbles so we can catch it at a top level element. I suggest removing it from this list. http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/dom/client/Document.java File user/src/com/google/gwt/dom/client/Document.java (right): http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/dom/client/Document.java#newcode18 user/src/com/google/gwt/dom/client/Document.java:18: import static com.google.gwt.dom.client.BrowserEvents.*; Do we have a rule against importing .*? http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/dom/client/Document.java#newcode571 user/src/com/google/gwt/dom/client/Document.java:571: @SuppressWarnings("deprecation") Do you need to suppress deprecation on a deprecated method? http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplTrident.java File user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplTrident.java (right): http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplTrident.java#newcode162 user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImplTrident.java:162: if (BrowserEvents.FOCUSIN.equals(type)) { FOCUSIN is IE specific. I would leave the string in this case, or create a static private String in this impl class. http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java File user/src/com/google/gwt/user/client/impl/DOMImplStandard.java (right): http://gwt-code-reviews.appspot.com/1550803/diff/1/user/src/com/google/gwt/user/client/impl/DOMImplStandard.java#newcode57 user/src/com/google/gwt/user/client/impl/DOMImplStandard.java:57: if (evt.getType().equals(BrowserEvents.MOUSEOUT)) { MOUSEOUT/MOUSEOVER http://gwt-code-reviews.appspot.com/1550803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
